[SMT] A user script that replaces '/watch?v=' with '/v/' for all YouTube links, on any page. Not just Reddit.

agentlame · 2012-05-26T08:40:02.741327+00:00

I'll post compiled extension files tomorrow. It's late and I am sick. I need sleep!

tetzy · 2012-05-26T08:29:21.559411+00:00

Wouldn't it make more sense if they were reversed? Red is usually "bad", no?

The default colors are the same as the up/down arrows, actually...

Denonhp1000 · 2012-05-26T07:35:36.901486+00:00

this has been reported by a number of users - only in Chrome. Not sure what's triggering it, but they seem to have fixed it by:

uninstalling RES
closing all instances of Chrome
starting chrome back up
checking chrome for updates and updating if applicable
reinstalling RES

please give that a shot

haydaw · 2012-05-26T07:33:28.202764+00:00

am I missing something, or are you asking for drop shadows?

also, you look to be on an old ass version of RES. you should really update.

ModernCreed · 2012-05-26T07:27:25.793774+00:00

Question. Why does RES actually change the original URL of the post, instead of just adding the expander button with your link?

Answer: It used to. It doesn't anymore.

However, nobody complained about the fact that it did until a contributor to RES (not me) added support for DeviantArt and Tumblr. (incidentally, while it did rewrite the link, it ALSO linked the user's profile so as not to take away the notion of giving artist credit ... but this wasn't enough to satiate some people)...

When it was just imgur and other basically anonymous image hosts, nobody so much as mentioned the fact that links were rewritten.

Why were links rewritten? 2 reasons:

1) Because it was simpler and more efficient to not have to store two separate URLs... the "real" URL, and the "expando" URL. It's just easier to say "set this link to be the direct link..."

2) More importantly, only Chrome supported adding URLs to your history that you didn't actually visit "as a page"... This may not sound like a big deal - but the #1 complaint for A LONG time about RES was "I open the image and it doesn't turn my link purple" -- the source of months and months of emails from people annoying me about it. The ONLY way to turn those links purple is to load them in an invisible iframe. The problem with loading those entire pages (rather than just an image URL) in an iFrame is that EVERY asset (images, even more javascript) must also be loaded. This is inefficient as all hell - especially for users who click the "view images" button and have 25, 50 or even 100 links on the same page. This would make your computer slow as balls.

In the end, once DA and tumblr were added and peope completely lost their shit... (no, seriously.. as in I got hate mail out the wazoo over it) - I updated RES to preserve the original link.

I did this at the expense of reasonable performance for users of Opera and Safari, because at least in Chrome and now recently Firefox I have the ability to do this without the iframe hack. I kind of hate that I had to do this, but I got sick of the hatemail and PMs from people over the whole situation and I figure Chrome+Firefox probably makes up 80% of RES's user base so it was a compromise I was willing to finally make.

agentlame · 2012-05-26T07:18:01.401844+00:00

not to be a downer, but actually just swapping strings like you're doing will miss a lot of links (and break them) as well... sometimes, a link might be: /watch?feature_related=blahblah&v=videoID -- as a random example...

I've gone ahead and done the screencast I promised and made this extension with BabelExt... not trying to upstage anyone, /u/agentlame just gave me the perfect simple idea to make a really fast extension for 4 browsers...

agentlame · 2012-05-26T06:19:18.242506+00:00

I realize someone beat me to it... but I've got my screencast done.. I'm encoding it now!

appropriate-username · 2012-05-26T04:32:02.125123+00:00

sure it technically could but that'd be a ton of wasted resources, errored hits to imgur's API, etc... it'd be extremely wasteful, potentially very slow, and end up in a poor user experience.

adharma · 2012-05-26T01:17:20.624732+00:00

Thank you as always, MrGrim!

adharma · 2012-05-26T00:39:07.915257+00:00

fair enough, thanks.. I'm just a little extra protective :-)

adharma · 2012-05-26T00:35:47.630316+00:00

The fix may be a nice temporary fix but also has the side effect of no longer giving credit / linking to DeviantArt and Tumblr artists, which RES does when it allows inline images...

adharma · 2012-05-26T00:28:48.550040+00:00

To clarify: not really an "RES issue" -- it's an imgur issue that affects RES.

joke-away · 2012-05-26T00:25:35.057809+00:00

I recognize it's not going to capture everyone -- but it has definitely worked to stop most people from posting here...

The only time we've had a real problem since the switch is today with this whole insane imgur mess...

appropriate-username · 2012-05-26T00:18:27.788434+00:00

While a funny suggestion: what's happening right now isn't something RES could do "on purpose"...

Basically RES asks imgur "what's the direct URL for this image?" and imgur comes back with info...

The best RES could do is pick random letters and hope it's a real image on imgur... but 99% of the time it probably would just be a broken link... sorry :-)

honestbleeps · 2012-05-26T00:14:33.692642+00:00

I can't believe you still put up with Redditors and keep working on RES. Hope this situation is resolved smoothly for you.

Thanks. Sometimes I can't believe it either. :-\

joke-away · 2012-05-26T00:08:10.653604+00:00

I don't mean to be too, but what was the reason for the split?

The reason for the split is really two reasons:

1) We wanted to make /r/Enhancement worth subscribing to. People started unsubscribing because it was way too many bug reports (usually dupes or not actually bugs from people who weren't so tech savvy) and we wanted /r/Enhancement to be more of a place to learn about it, make feature requests, discuss interesting ways to use it, etc...

2) It's WAY easier on me as a developer and on the mods if bugs are all in one place.. It gives us all an easier means of making sure we don't lose a bug report in the shuffle, etc...

I've got years of experience in Customer Support positions (though thankfully I've been out of it for a few years) and I've learned that if you have a process in place that users are consistently missing or ignoring, it's because you're doing something that is either difficult, non-obvious, or that doesn't make sense to them.

I'm going to sound like a jerk here, but...

If you're running RES and you manage to post a bug in /r/Enhancement - you've either slipped through a minor crack or you're purposefully skirting around the rules.

Why? Because if you try to submit to /r/Enhancement you're walked through a thing that FORCES you to post bugs to RESIssues... Give it a shot for yourself.

ModernCreed · 2012-05-26T00:01:33.312558+00:00

you're welcome...

mind making a final-final edit? RES didn't really dun goofed. ;-)

honestbleeps · 2012-05-25T23:55:31.306422+00:00

you mean imgur is poorly implemented and run by under qualified admins who cant keep their systems running more then 50% of the time? what a SHOCK.

No. I don't mean that.

the imgur folks are good people, friendly to work with, and provide a free service. I've definitely not seen any significant downtime issues with it. Maybe it's something on your end?

joke-away · 2012-05-25T23:53:37.488756+00:00

thank you. nobody will listen, but... thank you.

ModernCreed · 2012-05-25T23:52:40.571217+00:00

Hi guys.

I wrote RES. here's what's going on:

Imgur's API is returning the wrong data when RES makes an API call.

"WTF does that mean?!"

Okay, so say you link to imgur.com/abcde

RES can't open that "in line" unless it can turn that into a direct image URL. Since we don't know if it's a JPG, a PNG or a GIF, reddit basically says "hey, imgur! what's the direct image link for abcde?"

Imgur usually comes back with something like "yo! that's i.imgur.com/abcde.jpg - have a good day!"

Instead, though, just today - it started coming back with "yo! that's i.imgur.com/TROLO.jpg - have a good day! (tee hee hee)"...

The reason this doesn't affect users who aren't running RES is that they're not ever making API calls to get the "direct URL".

I have NO reason whatsoever to believe that this is intentional on imgur's part "screwing with RES"... MrGrim and I have had several email exchanges and he's a cool dude who wouldn't do this to RES users intentionally. It's probably a bug on imgur that will be ironed out soonish.

qwer777 · 2012-05-25T23:48:01.456109+00:00

you running any other addons? reddit comment boxes, etc?

honestbleeps · 2012-05-25T23:47:25.170196+00:00

I can't help but wonder if this "error" on imgur's part was caused by the awesome in-line image viewer allowing you to view imgur.com images without ads (for those who don't also have adblocker.) /tinfoilhat

no. /u/MrGrim is well aware and I've offered on multiple occasions to work with him on even allowing him to display (preferably unobtrusive) ads within expanded RES images.

He's said he's cool with how it works now on several occasions.

adharma · 2012-05-25T23:46:05.382640+00:00

it's an imgur issue, not a RES issue. It affects RES (and not reddit without RES) because the API is broken right now.

ModernCreed · 2012-05-25T23:42:19.618398+00:00

in the future: please remember that bug reports belong in /r/RESissues

Well-rounded 2012-02-15	Secret Santa 2011
Summer Santa 2011	Four-Year Club
reddit mold	reddit gold Charter Member
Charter Member	Verified Email

honestbleeps

TROPHY CASE

you'll need to login or register to do that

create a new account

login